[GCM] Fix crash during connection races

[GCM] Fix crash during connection races

If a connection attempt is triggered while a connection is open, but not
active (for example due to a socket error), make sure the old connection
is closed before reattempting to connect.

BUG=462319
Committed: https://crrev.com/3ca5141f50f9bb9367f1969e904900fecd9aa49e
Cr-Commit-Position: refs/heads/master@{#319201}

[Nicolas Zea, 2015-03-04 00:10:11]

zea@chromium.org changed reviewers:
+ fgorski@chromium.org

[Nicolas Zea, 2015-03-04 00:10:11]

PTAL

[fgorski, 2015-03-04 17:43:04]

lgtm

https://codereview.chromium.org/980433003/diff/1/google_apis/gcm/engine/conne...
File google_apis/gcm/engine/connection_factory_impl.cc (right):

https://codereview.chromium.org/980433003/diff/1/google_apis/gcm/engine/conne...
google_apis/gcm/engine/connection_factory_impl.cc:221: // effect if we're
already in the process of connecting.
To confirm. There is no need to close socket here, right?

[Nicolas Zea, 2015-03-04 17:56:42]

https://codereview.chromium.org/980433003/diff/1/google_apis/gcm/engine/conne...
File google_apis/gcm/engine/connection_factory_impl.cc (right):

https://codereview.chromium.org/980433003/diff/1/google_apis/gcm/engine/conne...
google_apis/gcm/engine/connection_factory_impl.cc:221: // effect if we're
already in the process of connecting.
On 2015/03/04 17:43:04, fgorski wrote:
> To confirm. There is no need to close socket here, right?

We do it on line 204 above.

[Nicolas Zea, 2015-03-04 17:56:45]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-03-04 17:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/980433003/1

[commit-bot: I haz the power, 2015-03-04 19:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 19:57:59]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[Nicolas Zea, 2015-03-05 00:24:06]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2015-03-05 00:25:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/980433003/1

[commit-bot: I haz the power, 2015-03-05 02:58:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-05 02:59:54]

Patchset 1 (id:??) landed as
https://crrev.com/3ca5141f50f9bb9367f1969e904900fecd9aa49e
Cr-Commit-Position: refs/heads/master@{#319201}