[GCM] Fix crash during connection races

google_apis/gcm/engine/fake_connection_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/fake_connection_handler.h"
 
 #include "base/logging.h"
 #include "google_apis/gcm/base/mcs_util.h"
 #include "net/socket/stream_socket.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 14 matching lines @@
 
 }  // namespace
 
 FakeConnectionHandler::FakeConnectionHandler(
     const ConnectionHandler::ProtoReceivedCallback& read_callback,
     const ConnectionHandler::ProtoSentCallback& write_callback)
     : read_callback_(read_callback),
       write_callback_(write_callback),
       fail_login_(false),
       fail_send_(false),
-      initialized_(false) {
+      initialized_(false),
+      had_error_(false) {
 }
 
 FakeConnectionHandler::~FakeConnectionHandler() {
 }
 
 void FakeConnectionHandler::Init(const mcs_proto::LoginRequest& login_request,
                                  net::StreamSocket* socket) {
   ASSERT_GE(expected_outgoing_messages_.size(), 1U);
   EXPECT_EQ(expected_outgoing_messages_.front().SerializeAsString(),
             login_request.SerializeAsString());
   expected_outgoing_messages_.pop_front();
   DVLOG(1) << "Received init call.";
   read_callback_.Run(BuildLoginResponse(fail_login_));
   initialized_ = !fail_login_;
 }
 
 void FakeConnectionHandler::Reset() {
   initialized_ = false;
+  had_error_ = false;
 }
 
 bool FakeConnectionHandler::CanSendMessage() const {
-  return initialized_;
+  return initialized_ && !had_error_;
 }
 
 void FakeConnectionHandler::SendMessage(
     const google::protobuf::MessageLite& message) {
   if (expected_outgoing_messages_.empty())
     FAIL() << "Unexpected message sent.";
   EXPECT_EQ(expected_outgoing_messages_.front().SerializeAsString(),
             message.SerializeAsString());
   expected_outgoing_messages_.pop_front();
   DVLOG(1) << "Received message, "
@@ skipping 14 matching lines @@
 
 bool FakeConnectionHandler::AllOutgoingMessagesReceived() const {
   return expected_outgoing_messages_.empty();
 }
 
 void FakeConnectionHandler::ReceiveMessage(const MCSMessage& message) {
   read_callback_.Run(message.CloneProtobuf());
 }
 
 }  // namespace gcm