Extensions: Switch to new permission message system, part I

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 97ea32ef00c907591f14456836f227fe14fbb610..3db8cdbb6e895eb69394e201c90ee9adc1c0854b 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1018,7 +1018,7 @@ void ExtensionService::RecordPermissionMessagesHistogram(
       base::HistogramBase::kUmaTargetedHistogramFlag);
 
   PermissionMessages permissions =
-      extension->permissions_data()->GetPermissionMessages();
+      extension->permissions_data()->GetLegacyPermissionMessages();

[Marc Treib, 2015/03/09 14:08:02]

Unfortunately, we can't just switch to the new system here, since the old IDs
are used in a histogram. We'll have to break that if we want to actually remove
the old stuff :-(

[Yoyo Zhou, 2015/03/11 01:33:23]

Can we introduce a new histogram? I imagine we are still interested in
collecting this data, but if we're measuring something different, we need a new
histogram. Of course, I don't think we want to deprecate the old one before the
new one is ready.

[Marc Treib, 2015/03/11 13:08:52]

Yes, I think we'll introduce a new histogram to (eventually) replace this one.
I'd like to add the new histogram in a separate CL though; this one is already
way too large.

   if (permissions.empty()) {
     counter->Add(PermissionMessage::kNone);
   } else {