chrome/browser/apps/ephemeral_app_launcher.cc - Issue 980353003: Extensions: Switch to new permission message system, part I

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 980353003: Extensions: Switch to new permission message system, part I (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup;rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/ephemeral_app_launcher.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc

index 469602ce94c57cfee1440e9f0249fcce0119fbea..32379904a374eed3f5a4aea3c2b364f26efa2082 100644

--- a/chrome/browser/apps/ephemeral_app_launcher.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher.cc

@@ -393,8 +393,8 @@ EphemeralAppLauncher::CreateInstallPrompt() const {

// Skip the prompt by returning null if the app does not need to display

// permission warnings.

- extensions::PermissionMessages permissions =

- extension->permissions_data()->GetPermissionMessages();

+ extensions::CoalescedPermissionMessages permissions =

+ extension->permissions_data()->GetCoalescedPermissionMessages();

if (permissions.empty())

return NULL;

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')