Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 980333002: DM: support non-fatal errors (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org, msarett
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: support non-fatal errors Tasks that produce a non-fatal error will bail out before writing their output to disk and hash to dm.json, but not count as failures. This also makes true failures bail out before writing their results. If the DM program failed, we probably don't want to triage that image result. We use this new feature first to skip image subset decoding when we detect it's not supported. Here's a snippet of an example run, where in this case only .webp are subset decodable: ... ( 15MB 12) 172µs 8888 subset color_wheel.jpg (skipped: Subset decoding not supported.) ( 15MB 11) 9.05ms 8888 subset randPixels.webp ( 16MB 10) 863µs 8888 subset baby_tux.png (skipped: Subset decoding not supported.) ... Only outputs corresponding to the .webp show up, both on disk and in the .json. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4089ef7c982592fadeec441438c551ffb4c746be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M dm/DM.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +24 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
I think this should let us skip uninteresting decodes ( return Error::Nonfatal("uninteresting"); ) without having ...
5 years, 9 months ago (2015-03-05 16:27:12 UTC) #2
scroggo
On 2015/03/05 16:27:12, mtklein_C wrote: > I think this should let us skip uninteresting decodes ...
5 years, 9 months ago (2015-03-05 16:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980333002/1
5 years, 9 months ago (2015-03-05 16:34:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980333002/1
5 years, 9 months ago (2015-03-05 16:35:04 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 16:40:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4089ef7c982592fadeec441438c551ffb4c746be

Powered by Google App Engine
This is Rietveld 408576698