dm/DMSrcSink.cpp - Issue 980333002: DM: support non-fatal errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMSrcSink.cpp

Issue 980333002: DM: support non-fatal errors (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMSrcSink.cpp

diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp

index 2060ce2d6833561fdece352aca6cf95d1fe8f2b6..d99f0115b3ad108bbc368361303d0daa9babfefb 100644

--- a/dm/DMSrcSink.cpp

+++ b/dm/DMSrcSink.cpp

@@ -92,7 +92,7 @@ Error ImageSrc::draw(SkCanvas* canvas) const {

stream->rewind();

int w,h;

if (!decoder->buildTileIndex(stream.detach(), &w, &h) || w*h == 1) {

- return ""; // Not an error. Subset decoding is not always supported.

+ return Error::Nonfatal("Subset decoding not supported.");

}

// Divide the image into subsets that cover the entire image.

« no previous file with comments | « dm/DMSrcSink.h ('k') | no next file » | no next file with comments »