Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 980273005: Clean up HTMLObjectElement/HTMLEmbedElement layoutObjectIsNeeded (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up HTMLObjectElement/HTMLEmbedElement layoutObjectIsNeeded LayoutObjectIsNeeded is only called by shouldCreateRenderer, which is only called by createLayoutObjectIfNeeded, which is only called by Element::attach, which checks that the Document is in style recalc, so not in detached state. This means we can remove the frame() checks as the FIXME indicates. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191463

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/core/html/HTMLEmbedElement.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-06 00:41:36 UTC) #2
chrishtr
lgtm
5 years, 9 months ago (2015-03-06 20:10:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980273005/1
5 years, 9 months ago (2015-03-06 20:11:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/30734)
5 years, 9 months ago (2015-03-06 20:15:39 UTC) #7
rwlbuis
On 2015/03/06 20:10:05, chrishtr wrote: > lgtm Thanks! The problem is likely the recent renaming, ...
5 years, 9 months ago (2015-03-06 20:18:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980273005/20001
5 years, 9 months ago (2015-03-06 20:23:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980273005/20001
5 years, 9 months ago (2015-03-06 21:58:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980273005/20001
5 years, 9 months ago (2015-03-06 22:33:46 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:29:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191463

Powered by Google App Engine
This is Rietveld 408576698