Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: Source/core/html/HTMLObjectElement.h

Issue 980273005: Clean up HTMLObjectElement/HTMLEmbedElement layoutObjectIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 private: 75 private:
76 HTMLObjectElement(Document&, HTMLFormElement*, bool createdByParser); 76 HTMLObjectElement(Document&, HTMLFormElement*, bool createdByParser);
77 77
78 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; 78 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;
79 virtual bool isPresentationAttribute(const QualifiedName&) const override; 79 virtual bool isPresentationAttribute(const QualifiedName&) const override;
80 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override; 80 virtual void collectStyleForPresentationAttribute(const QualifiedName&, cons t AtomicString&, MutableStylePropertySet*) override;
81 81
82 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override; 82 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
83 virtual void removedFrom(ContainerNode*) override; 83 virtual void removedFrom(ContainerNode*) override;
84 84
85 virtual bool layoutObjectIsNeeded(const LayoutStyle&) override;
86 virtual void didMoveToNewDocument(Document& oldDocument) override; 85 virtual void didMoveToNewDocument(Document& oldDocument) override;
87 86
88 virtual void childrenChanged(const ChildrenChange&) override; 87 virtual void childrenChanged(const ChildrenChange&) override;
89 88
90 virtual bool isURLAttribute(const Attribute&) const override; 89 virtual bool isURLAttribute(const Attribute&) const override;
91 virtual bool hasLegalLinkAttribute(const QualifiedName&) const override; 90 virtual bool hasLegalLinkAttribute(const QualifiedName&) const override;
92 virtual const QualifiedName& subResourceAttributeName() const override; 91 virtual const QualifiedName& subResourceAttributeName() const override;
93 virtual const AtomicString imageSourceURL() const override; 92 virtual const AtomicString imageSourceURL() const override;
94 93
95 virtual LayoutPart* existingLayoutPart() const override; 94 virtual LayoutPart* existingLayoutPart() const override;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 const HTMLObjectElement& objectElement = static_cast<const HTMLObjectElement &>(element); 142 const HTMLObjectElement& objectElement = static_cast<const HTMLObjectElement &>(element);
144 // We need to assert after the cast because FormAssociatedElement doesn't 143 // We need to assert after the cast because FormAssociatedElement doesn't
145 // have hasTagName. 144 // have hasTagName.
146 ASSERT_WITH_SECURITY_IMPLICATION(objectElement.hasTagName(HTMLNames::objectT ag)); 145 ASSERT_WITH_SECURITY_IMPLICATION(objectElement.hasTagName(HTMLNames::objectT ag));
147 return objectElement; 146 return objectElement;
148 } 147 }
149 148
150 } // namespace blink 149 } // namespace blink
151 150
152 #endif // HTMLObjectElement_h 151 #endif // HTMLObjectElement_h
OLDNEW
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698