Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 980233002: [svg2] Make 'cx', 'cy' and 'r' presentation attributes (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, shans, eae+blinkwatch, fs, apavlov+blink_chromium.org, Steve Block, rwlbuis, krit, blink-reviews-css, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, pdr+svgwatchlist_chromium.org, Eric Willigers, rjwright, blink-reviews-style_chromium.org, zoltan1, Dominik Röttsches, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, kouhei+svg_chromium.org, leviw+renderwatch, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[svg2] Make 'cx', 'cy' and 'r' presentation attributes The following elements' cx and cy attributes have been made into presentation attributes: * circle * ellipse and the 'r' attribute on <circle>. BUG=400725 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191575

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : tests + fixups #

Patch Set 4 : rebase #

Total comments: 8

Patch Set 5 : codereview fixes #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -185 lines) Patch
M LayoutTests/svg/css/parse-length.html View 1 2 3 4 1 chunk +38 lines, -72 lines 0 comments Download
M LayoutTests/svg/css/parse-length-expected.txt View 1 2 3 4 5 2 chunks +224 lines, -45 lines 0 comments Download
M LayoutTests/transitions/svg-layout-transition.html View 1 2 4 chunks +49 lines, -6 lines 0 comments Download
M LayoutTests/transitions/svg-layout-transition-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.cpp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/LayoutStyleCSSValueMapping.cpp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/layout/style/LayoutStyle.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.h View 1 2 3 4 5 4 chunks +21 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyle.cpp View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/style/SVGLayoutStyleDefs.cpp View 1 2 3 4 5 3 chunks +11 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGEllipse.cpp View 1 chunk +10 lines, -12 lines 0 comments Download
M Source/core/layout/svg/SVGPathData.cpp View 1 2 3 2 chunks +15 lines, -8 lines 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 1 2 3 2 chunks +35 lines, -13 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 1 2 3 3 chunks +15 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-09 12:10:17 UTC) #2
fs
Test nits, otherwise LGTM. https://codereview.chromium.org/980233002/diff/60001/LayoutTests/svg/css/parse-length.html File LayoutTests/svg/css/parse-length.html (right): https://codereview.chromium.org/980233002/diff/60001/LayoutTests/svg/css/parse-length.html#newcode36 LayoutTests/svg/css/parse-length.html:36: for (var i = 0; ...
5 years, 9 months ago (2015-03-09 12:34:33 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/980233002/diff/60001/LayoutTests/svg/css/parse-length.html File LayoutTests/svg/css/parse-length.html (right): https://codereview.chromium.org/980233002/diff/60001/LayoutTests/svg/css/parse-length.html#newcode36 LayoutTests/svg/css/parse-length.html:36: for (var i = 0; i < xyelements.length; i++) ...
5 years, 9 months ago (2015-03-09 13:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980233002/80001
5 years, 9 months ago (2015-03-09 14:00:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980233002/100001
5 years, 9 months ago (2015-03-09 17:35:40 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:04:41 UTC) #11
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191575

Powered by Google App Engine
This is Rietveld 408576698