Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 980233002: [svg2] Make 'cx', 'cy' and 'r' presentation attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 980233002: [svg2] Make 'cx', 'cy' and 'r' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webexposed/css-properties-as-js-properties-expected.txt ('k') | Source/core/animation/css/CSSPropertyEquality.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index b8996a697dab8022c1101312f0a84a0aedc62518..b88291e15f852807777cc56cc2f965473f7c4eb8 100644

--- a/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -537,10 +537,16 @@ PassRefPtrWillBeRawPtr<AnimatableValue> CSSAnimatableValueFactory::create(CSSPro

return AnimatableUnknown::create(CSSPrimitiveValue::create(style.verticalAlign()));

case CSSPropertyVisibility:

return AnimatableVisibility::create(style.visibility());

+ case CSSPropertyCx:

+ return createFromLength(style.svgStyle().cx(), style);

+ case CSSPropertyCy:

+ return createFromLength(style.svgStyle().cy(), style);

case CSSPropertyX:

return createFromLength(style.svgStyle().x(), style);

case CSSPropertyY:

return createFromLength(style.svgStyle().y(), style);

+ case CSSPropertyR:

+ return createFromLength(style.svgStyle().r(), style);

case CSSPropertyRx:

return createFromLength(style.svgStyle().rx(), style);

case CSSPropertyRy: