Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 980173003: reland rename UniquePersistent to Global (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

reland rename UniquePersistent to Global BUG= Committed: https://crrev.com/00c52d424a9a9c9f3f26503eebdc72ae8eafa0c2 Cr-Commit-Position: refs/heads/master@{#27018}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M include/v8.h View 1 2 4 chunks +24 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 10 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Sven Panne
lgtm
5 years, 9 months ago (2015-03-05 11:16:41 UTC) #3
Sven Panne
lgtm lgtm
5 years, 9 months ago (2015-03-05 11:16:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980173003/20001
5 years, 9 months ago (2015-03-05 11:20:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 11:40:42 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3f5ae16c62b031ad572f750d81ffc71c5d6d1f9b Cr-Commit-Position: refs/heads/master@{#27011}
5 years, 9 months ago (2015-03-05 11:40:57 UTC) #9
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/983653002/ by machenbach@chromium.org. ...
5 years, 9 months ago (2015-03-05 12:09:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980173003/40001
5 years, 9 months ago (2015-03-05 12:57:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-05 13:26:24 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 13:26:50 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/00c52d424a9a9c9f3f26503eebdc72ae8eafa0c2
Cr-Commit-Position: refs/heads/master@{#27018}

Powered by Google App Engine
This is Rietveld 408576698