[rAC, OSX] Force better initial size for sign-in (2nd try)

[rAC, OSX] Force better initial size for sign-in (2nd try)

This is a re-land of http://crrev.com/103853004 (r240566), which was
reverted in http://crrev.com/113913008 (r240603)

The revert was due to a test failure with the root cause that
AutofillDialogBrowserTest shows the dialog, but never runs the
NSRunLoop - which means the visual display is not fully updated. And
showing the sign-in dialog requires the main dialog's size to be non-
zero.

Fixes added:
* AutofillSignInDelegate DCHECKs for invalid sizes (better callstacks)
* AutofillDialogBrowserTest cycles run loops whenever dialog is shown

---- original description ----
Open the sign-in dialog with an initial size equal to the current
dialog. This avoids one unnecessary resize until the content is loaded
and makes the visual experience less jarring.
---- end original description ----

TBR=jochen@chromium.org
R=isherman@chromium.org
BUG=325518
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241009

[groby-ooo-7-16, 2013-12-13 23:57:29]

ilya:PTAL - this fixes a test breakage.
jochen: FYI

[Ilya Sherman, 2013-12-13 23:59:47]

LGTM.  For future reference, it's quite helpful to upload the original CL as
patch set 1, and then the revised diff as patch set 2.  That way, it's easy for
reviewers to see the diff between reviewed and unreviewed code.  Thanks :)

[commit-bot: I haz the power, 2013-12-14 00:05:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/97993006/1

[groby-ooo-7-16, 2013-12-14 00:10:31]

Sorry, thought I had done that :(


On Fri, Dec 13, 2013 at 3:59 PM, <isherman@chromium.org> wrote:

> LGTM.  For future reference, it's quite helpful to upload the original CL
> as
> patch set 1, and then the revised diff as patch set 2.  That way, it's
> easy for
> reviewers to see the diff between reviewed and unreviewed code.  Thanks :)
>
> https://codereview.chromium.org/97993006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-14 02:41:07]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-14 02:46:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/97993006/1

[commit-bot: I haz the power, 2013-12-14 06:06:25]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-16 17:56:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/97993006/1

[commit-bot: I haz the power, 2013-12-16 20:35:20]

Change committed as 241009