[rAC, OSX] Force better initial size for sign-in (2nd try)

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 39 matching lines @@
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "ui/base/window_open_disposition.h"
 #include "url/gurl.h"
 
+#if defined(OS_MACOSX)
+#include "base/mac/mac_util.h"
+#include "base/mac/scoped_nsautorelease_pool.h"
+#include "chrome/browser/ui/cocoa/run_loop_testing.h"
+#endif
+
 namespace autofill {
 
 namespace {
 
 using testing::_;
 
 void MockCallback(const FormStructure*) {}
 
 class MockAutofillMetrics : public AutofillMetrics {
  public:
@@ skipping 205 matching lines @@
 class AutofillDialogControllerTest : public InProcessBrowserTest {
  public:
   AutofillDialogControllerTest() {}
   virtual ~AutofillDialogControllerTest() {}
 
   virtual void SetUpOnMainThread() OVERRIDE {
     autofill::test::DisableSystemServices(browser()->profile());
     InitializeController();
   }
 
+  // A helper function that cycles the MessageLoop, and on Mac, the Cocoa run
+  // loop. It also drains the NSAutoreleasePool.
+  void CycleRunLoops() {
+    content::RunAllPendingInMessageLoop();
+#if defined(OS_MACOSX)
+    chrome::testing::NSRunLoopRunAllPending();
+    AutoreleasePool()->Recycle();
+#endif
+  }
+
   void InitializeController() {
     FormData form;
     form.name = ASCIIToUTF16("TestForm");
     form.method = ASCIIToUTF16("POST");
     form.origin = GURL("http://example.com/form.html");
     form.action = GURL("http://example.com/submit.html");
     form.user_submitted = true;
 
     FormFieldData field;
     field.autocomplete_attribute = "shipping tel";
     form.fields.push_back(field);
 
     test_generated_bubble_controller_ =
         new testing::NiceMock<TestGeneratedCreditCardBubbleController>(
             GetActiveWebContents());
     ASSERT_TRUE(test_generated_bubble_controller_->IsInstalled());
 
     message_loop_runner_ = new content::MessageLoopRunner;
     controller_ = new TestAutofillDialogController(
         GetActiveWebContents(),
         form,
         metric_logger_,
         message_loop_runner_);
     controller_->Show();
+    CycleRunLoops();  // Ensures dialog is fully visible.
   }
 
   content::WebContents* GetActiveWebContents() {
     return browser()->tab_strip_model()->GetActiveWebContents();
   }
 
   const MockAutofillMetrics& metric_logger() { return metric_logger_; }
   TestAutofillDialogController* controller() { return controller_; }
 
   void RunMessageLoop() {
@@ skipping 926 matching lines @@
                                 content::Referrer(),
                                 CURRENT_TAB,
                                 content::PAGE_TRANSITION_LINK,
                                 true);
   int num_tabs = browser()->tab_strip_model()->count();
   sign_in_contents->GetDelegate()->OpenURLFromTab(sign_in_contents, params);
   EXPECT_EQ(num_tabs + 1, browser()->tab_strip_model()->count());
 }
 
 }  // namespace autofill