Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 979883002: [S.P.] Move clip painting to SVGClipPainter. (Closed)

Created:
5 years, 9 months ago by Erik Dahlström (inactive)
Modified:
5 years, 9 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[S.P.] Move clip painting to SVGClipPainter. BUG=462077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191430

Patch Set 1 #

Patch Set 2 : code shuffling #

Total comments: 4

Patch Set 3 : codereview fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -144 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.h View 1 3 chunks +6 lines, -20 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 4 chunks +7 lines, -115 lines 0 comments Download
M Source/core/paint/LayerPainter.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
A Source/core/paint/SVGClipPainter.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A Source/core/paint/SVGClipPainter.cpp View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
M Source/core/paint/SVGPaintContext.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/paint/SVGPaintContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Erik Dahlström (inactive)
5 years, 9 months ago (2015-03-05 09:35:10 UTC) #2
pdr.
LGTM with minor nits https://codereview.chromium.org/979883002/diff/20001/Source/core/paint/SVGClipPainter.cpp File Source/core/paint/SVGClipPainter.cpp (right): https://codereview.chromium.org/979883002/diff/20001/Source/core/paint/SVGClipPainter.cpp#newcode104 Source/core/paint/SVGClipPainter.cpp:104: { Are these braces needed? ...
5 years, 9 months ago (2015-03-05 22:21:17 UTC) #3
Erik Dahlström (inactive)
https://codereview.chromium.org/979883002/diff/20001/Source/core/paint/SVGClipPainter.cpp File Source/core/paint/SVGClipPainter.cpp (right): https://codereview.chromium.org/979883002/diff/20001/Source/core/paint/SVGClipPainter.cpp#newcode104 Source/core/paint/SVGClipPainter.cpp:104: { On 2015/03/05 22:21:16, pdr wrote: > Are these ...
5 years, 9 months ago (2015-03-06 11:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979883002/40001
5 years, 9 months ago (2015-03-06 11:56:31 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 11:59:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191430

Powered by Google App Engine
This is Rietveld 408576698