Switch Android GPU bot to use cloud storage for pixel reference images.

Switch Android GPU bot to use cloud storage for pixel reference images.

BUG=331125
R=navabi@chromium.org, navabi@google.com, skyostil@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243372

[Ken Russell (switch to Gerrit), 2013-12-30 23:14:30]

skyostil: please review
yfriedman: OWNERS review

Compare to https://codereview.chromium.org/121883002 , which switched over all
of the GPU bots except this one.

Note: not tested (I don't know how to test a change like this locally).

[Sami, 2014-01-03 13:20:20]

lgtm, thanks.

I'm not aware of any easy way to test these types of buildbot changes locally.
It is possible to run a buildbot master and slave locally (go/fgumi), but the
process is fairly involved and I haven't tried it recently.

Could you update
http://www.chromium.org/developers/how-tos/gpu-wrangling#TOC-Wrangling with
instructions on how to work with reference images in cloud storage?

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:468:
options.build_properties.get('buildername', 'noname'))])
Probably not worth going into in this patch, but it's odd that we can't assume
the builder name is always there.

[Yaron, 2014-01-06 17:19:36]

Sorry for the delay but I was out for holidays. I think navabi should approve
changes to buildbots.

[navabi, 2014-01-06 21:35:21]

On 2014/01/06 17:19:36, Yaron wrote:
> Sorry for the delay but I was out for holidays. I think navabi should approve
> changes to buildbots.

One way to test, without bringing up a local master/slave, is to run
build/android/buildbot/bb_device_steps.py with the arguments you expect will be
passed to the script.  This will show the steps executed by bb_device_steps.py.

If that looks good, then this lgtm.

[navabi, 2014-01-06 21:35:33]

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:468:
options.build_properties.get('buildername', 'noname'))])
On 2014/01/03 13:20:20, Sami wrote:
> Probably not worth going into in this patch, but it's odd that we can't assume
> the builder name is always there.

agreed.

[navabi1, 2014-01-06 21:36:36]

lgtm (from chromium.org account)

[Ken Russell (switch to Gerrit), 2014-01-07 00:48:28]

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/97983005/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:468:
options.build_properties.get('buildername', 'noname'))])
On 2014/01/06 21:35:33, navabi wrote:
> On 2014/01/03 13:20:20, Sami wrote:
> > Probably not worth going into in this patch, but it's odd that we can't
assume
> > the builder name is always there.
> 
> agreed.

I suspect that we can assume it, but having a fallback reduces the possibility
of breakage in my opinion.

[Ken Russell (switch to Gerrit), 2014-01-07 02:50:03]

On 2014/01/03 13:20:20, Sami wrote:
> 
> Could you update
> http://www.chromium.org/developers/how-tos/gpu-wrangling#TOC-Wrangling with
> instructions on how to work with reference images in cloud storage?

Documentation has been updated.

[Ken Russell (switch to Gerrit), 2014-01-07 20:10:17]

Committed patchset #1 manually as r243372.