Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 97983005: Switch Android GPU bot to use cloud storage for pixel reference images. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index 26708cd1c9346cc7e41a882989c7514fb6120544..f59d37348390ad07e2f65db20d83236f50966c8f 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -452,13 +452,20 @@ def RunGPUTests(options):
bb_annotations.PrintNamedStep('gpu_tests')
revision = _GetRevision(options)
- data_dir = os.path.join(DIR_BUILD_ROOT, 'content_gpu_data', 'telemetry')
RunCmd(['content/test/gpu/run_gpu_test',
- '--browser=android-content-shell',
- '--generated-dir=%s' % os.path.join(data_dir, 'generated'),
- '--reference-dir=%s' % os.path.join(data_dir, 'reference'),
- '--build-revision=%s' % revision,
- 'pixel'])
+ 'pixel',
+ '--browser',
+ 'android-content-shell',
+ '--build-revision',
+ str(revision),
+ '--upload-refimg-to-cloud-storage',
+ '--refimg-cloud-storage-bucket',
+ 'chromium-gpu-archive/reference-images',
+ '--os-type',
+ 'android',
+ '--test-machine-name',
+ EscapeBuilderName(
+ options.build_properties.get('buildername', 'noname'))])
Sami 2014/01/03 13:20:20 Probably not worth going into in this patch, but i
navabi 2014/01/06 21:35:33 agreed.
Ken Russell (switch to Gerrit) 2014/01/07 00:48:28 I suspect that we can assume it, but having a fall
bb_annotations.PrintNamedStep('webgl_conformance_tests')
RunCmd(['content/test/gpu/run_gpu_test',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698