Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 9796013: Set sourceUrl property of mountpoint info for gdata to empty string if mount fails. (Closed)

Created:
6 years, 8 months ago by tbarzic
Modified:
4 months, 3 weeks ago
Reviewers:
achuithb, zel
CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Set sourceUrl property of mountpoint info for gdata to empty string if mount fails. BUG=chromium-os:28112 TEST=manual on linux chromeos (verified we don't crash on debug build with no profile dir set) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127992

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
tbarzic
6 years, 8 months ago (2012-03-21 04:04:57 UTC) #1
zel
lgtm
6 years, 8 months ago (2012-03-21 04:28:15 UTC) #2
achuithb
6 years, 8 months ago (2012-03-21 19:38:28 UTC) #3
Thanks!

https://chromiumcodereview.appspot.com/9796013/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://chromiumcodereview.appspot.com/9796013/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:374: // If
mounting of gdata moutn point failed, we may not be able to convert
nit: moutn->mount

Powered by Google App Engine
This is Rietveld 408576698