Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 979503002: skip map files in test.sh diff (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M test/test.sh View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 9 months ago (2015-03-03 20:50:54 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/979503002/diff/1/test/test.sh File test/test.sh (right): https://codereview.chromium.org/979503002/diff/1/test/test.sh#newcode10 test/test.sh:10: # copied over from the sources and are ...
5 years, 9 months ago (2015-03-03 21:30:09 UTC) #3
Jennifer Messerly
thanks! https://codereview.chromium.org/979503002/diff/1/test/test.sh File test/test.sh (right): https://codereview.chromium.org/979503002/diff/1/test/test.sh#newcode10 test/test.sh:10: # copied over from the sources and are ...
5 years, 9 months ago (2015-03-03 22:08:18 UTC) #4
Jennifer Messerly
5 years, 9 months ago (2015-03-03 22:08:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a2dd9034819117d6f376ee83d9b66747c741c163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698