Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: test/test.sh

Issue 979503002: skip map files in test.sh diff (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test.sh
diff --git a/test/test.sh b/test/test.sh
index 53cca8507e3d940e292c2f0327ba06357d44954a..f8d94ec2faf2f99b4d2199eb74958f15245eb338 100755
--- a/test/test.sh
+++ b/test/test.sh
@@ -6,10 +6,14 @@ function fail {
return 1
}
+# Arguments passed to the diff tool. We exclude *.map files so they aren't
+# compared, as the diff is not human readable.
+DIFF_ARGS="-u -r -N --exclude=\*.map expect actual"
+
function show_diff {
echo "Fail: actual output did not match expected"
echo
- diff -u -r -N $1 $2 |\
+ diff $DIFF_ARGS |\
sed -e "s/^\(+.*\)/\1/" |\
sed -e "s/^\(-.*\)/\1/"
echo
@@ -36,12 +40,12 @@ dart -c test/all_tests.dart || fail
# validate codegen_test output
pushd test/codegen/ &> /dev/null
-diff -u -r -N expect actual > /dev/null || show_diff expect actual
+diff $DIFF_ARGS > /dev/null || show_diff
popd &> /dev/null
# validate dart_codegen_test output
pushd test/dart_codegen/ &> /dev/null
-diff -u -r -N expect actual > /dev/null || show_diff expect actual
+diff $DIFF_ARGS > /dev/null || show_diff
popd &> /dev/null
# run self host and analyzer after other tests, because they're ~seconds to run.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698