Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 97943002: Enable revealing the top-of-window views in immersive fullscreen when the owning window is inactive (Closed)

Created:
7 years ago by pkotwicz
Modified:
7 years ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Enable revealing the top-of-window views in immersive fullscreen when the mouse is hovered over the top edge of the fullscreen window but the fullscreen window is inactive. This is consistent to how hover works elsewhere on ChromeOS (e.g. the maximize/restore button's help bubble) BUG=319959 TEST=ImmersiveFullscreenControllerTest.Inactive R=jamescook TBR=sky (For change to DragTabToImmersiveBrowserOnSeparateDisplay test) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238287

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -106 lines) Patch
M ash/wm/immersive_fullscreen_controller.h View 2 chunks +1 line, -10 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 14 chunks +48 lines, -61 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 8 chunks +85 lines, -35 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
James, can you please take a look? https://codereview.chromium.org/97943002/diff/170001/ash/wm/immersive_fullscreen_controller.cc File ash/wm/immersive_fullscreen_controller.cc (right): https://codereview.chromium.org/97943002/diff/170001/ash/wm/immersive_fullscreen_controller.cc#newcode543 ash/wm/immersive_fullscreen_controller.cc:543: !native_window_->Contains(static_cast<aura::Window*>(event->target()))) { ...
7 years ago (2013-12-01 22:57:20 UTC) #1
James Cook
LGTM. Nice patch.
7 years ago (2013-12-02 17:58:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/97943002/170001
7 years ago (2013-12-02 18:46:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=179833
7 years ago (2013-12-02 20:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/97943002/210001
7 years ago (2013-12-02 22:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/97943002/210001
7 years ago (2013-12-02 23:07:47 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 03:18:02 UTC) #7
Message was sent while issue was closed.
Change committed as 238287

Powered by Google App Engine
This is Rietveld 408576698