Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 979173002: [turbofan] Preserve pending message while inside finally-block. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Preserve pending message while inside finally-block. This makes sure that any pending message is saved before entering and restored after exiting a finally block. It also makes sure that operand stacks are kept in sync to full-codegen. R=bmeurer@chromium.org TEST=cctest/test-run-jsexceptions/ThrowMessage Committed: https://crrev.com/e6ff16d6bfb87fe21ffbf9120afa2be703e3327d Cr-Commit-Position: refs/heads/master@{#27036}

Patch Set 1 #

Patch Set 2 : Remove debug output. #

Patch Set 3 : Fix bool rep. #

Total comments: 4

Patch Set 4 : Addressed comments by Benedikt. #

Patch Set 5 : Followup fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -19 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 2 3 4 5 chunks +42 lines, -16 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 1 2 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-05 15:50:09 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/979173002/diff/40001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/979173002/diff/40001/src/compiler/ast-graph-builder.cc#newcode2825 src/compiler/ast-graph-builder.cc:2825: jsgraph()->ZeroConstant()); This is probably wrong for the generic pipeline ...
5 years, 9 months ago (2015-03-06 04:50:49 UTC) #2
Michael Starzinger
https://codereview.chromium.org/979173002/diff/40001/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/979173002/diff/40001/src/compiler/ast-graph-builder.cc#newcode2825 src/compiler/ast-graph-builder.cc:2825: jsgraph()->ZeroConstant()); On 2015/03/06 04:50:49, Benedikt Meurer wrote: > This ...
5 years, 9 months ago (2015-03-06 09:47:36 UTC) #3
Benedikt Meurer
Nice, thanks. LGTM
5 years, 9 months ago (2015-03-06 09:48:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979173002/80001
5 years, 9 months ago (2015-03-06 10:08:46 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-06 10:15:54 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 10:16:11 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e6ff16d6bfb87fe21ffbf9120afa2be703e3327d
Cr-Commit-Position: refs/heads/master@{#27036}

Powered by Google App Engine
This is Rietveld 408576698