Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 979173002: [turbofan] Preserve pending message while inside finally-block. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Followup fixes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 898 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 } 909 }
910 910
911 //------------------------------------------------------------------ 911 //------------------------------------------------------------------
912 // Machine-level operators. 912 // Machine-level operators.
913 //------------------------------------------------------------------ 913 //------------------------------------------------------------------
914 case IrOpcode::kLoad: { 914 case IrOpcode::kLoad: {
915 // TODO(titzer): machine loads/stores need to know BaseTaggedness!? 915 // TODO(titzer): machine loads/stores need to know BaseTaggedness!?
916 MachineTypeUnion tBase = kRepTagged | kMachPtr; 916 MachineTypeUnion tBase = kRepTagged | kMachPtr;
917 LoadRepresentation rep = OpParameter<LoadRepresentation>(node); 917 LoadRepresentation rep = OpParameter<LoadRepresentation>(node);
918 ProcessInput(node, 0, tBase); // pointer or object 918 ProcessInput(node, 0, tBase); // pointer or object
919 ProcessInput(node, 1, kMachInt32); // index 919 ProcessInput(node, 1, kMachIntPtr); // index
920 ProcessRemainingInputs(node, 2); 920 ProcessRemainingInputs(node, 2);
921 SetOutput(node, rep); 921 SetOutput(node, rep);
922 break; 922 break;
923 } 923 }
924 case IrOpcode::kStore: { 924 case IrOpcode::kStore: {
925 // TODO(titzer): machine loads/stores need to know BaseTaggedness!? 925 // TODO(titzer): machine loads/stores need to know BaseTaggedness!?
926 MachineTypeUnion tBase = kRepTagged | kMachPtr; 926 MachineTypeUnion tBase = kRepTagged | kMachPtr;
927 StoreRepresentation rep = OpParameter<StoreRepresentation>(node); 927 StoreRepresentation rep = OpParameter<StoreRepresentation>(node);
928 ProcessInput(node, 0, tBase); // pointer or object 928 ProcessInput(node, 0, tBase); // pointer or object
929 ProcessInput(node, 1, kMachInt32); // index 929 ProcessInput(node, 1, kMachIntPtr); // index
930 ProcessInput(node, 2, rep.machine_type()); 930 ProcessInput(node, 2, rep.machine_type());
931 ProcessRemainingInputs(node, 3); 931 ProcessRemainingInputs(node, 3);
932 SetOutput(node, 0); 932 SetOutput(node, 0);
933 break; 933 break;
934 } 934 }
935 case IrOpcode::kWord32Shr: 935 case IrOpcode::kWord32Shr:
936 // We output unsigned int32 for shift right because JavaScript. 936 // We output unsigned int32 for shift right because JavaScript.
937 return VisitBinop(node, kMachUint32, kMachUint32); 937 return VisitBinop(node, kMachUint32, kMachUint32);
938 case IrOpcode::kWord32And: 938 case IrOpcode::kWord32And:
939 case IrOpcode::kWord32Or: 939 case IrOpcode::kWord32Or:
(...skipping 664 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 1604
1605 void SimplifiedLowering::DoStringLessThanOrEqual(Node* node) { 1605 void SimplifiedLowering::DoStringLessThanOrEqual(Node* node) {
1606 node->set_op(machine()->IntLessThanOrEqual()); 1606 node->set_op(machine()->IntLessThanOrEqual());
1607 node->ReplaceInput(0, StringComparison(node, true)); 1607 node->ReplaceInput(0, StringComparison(node, true));
1608 node->ReplaceInput(1, jsgraph()->SmiConstant(EQUAL)); 1608 node->ReplaceInput(1, jsgraph()->SmiConstant(EQUAL));
1609 } 1609 }
1610 1610
1611 } // namespace compiler 1611 } // namespace compiler
1612 } // namespace internal 1612 } // namespace internal
1613 } // namespace v8 1613 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698