Issue 97893002: aura/ash cleanup: Use a single window-key for constrained windows.

Issue 97893002: aura/ash cleanup: Use a single window-key for constrained windows. (Closed)

Created:
7 years ago by sadrul

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, kalyank, ben+ash_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura/ash cleanup: Use a single window-key for constrained windows. There is a kConstrainedWindowKey in both ash and aura::client namespace, which is pretty confusing when reading the code. So remove the ash version. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238195

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -10 lines)			Patch
M	ash/ash_constants.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ash/ash_constants.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/wm/solo_window_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/solo_window_tracker_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc	View	1 chunk	+0 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/97893002/diff/1/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc File chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc (right): https://codereview.chromium.org/97893002/diff/1/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc#newcode94 chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc:94: // TODO(wittman): remove once the new visual style ...

7 years ago (2013-12-02 21:41:46 UTC) #2

sadrul

7 years ago (2013-12-02 22:05:20 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/97893002/diff/1/chrome/browser/ui/views/web_c...
File chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc (right):

https://codereview.chromium.org/97893002/diff/1/chrome/browser/ui/views/web_c...
chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc:94: //
TODO(wittman): remove once the new visual style is complete
On 2013/12/02 21:41:46, sky wrote:
> Is the TODO still appropriate?

Whoops. I missed this before landing, sorry. Checked with wittman@, and the TODO
applies only to SetProperty, so it should be removed. I will put up a follow-up
CL shortly.

Expand Messages | Collapse Messages