aura/ash cleanup: Use a single window-key for constrained windows.

chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/ui/views/constrained_window_views.h"
 #include "components/web_modal/native_web_contents_modal_dialog_manager.h"
@@ skipping 73 matching lines @@
 
 #if defined(USE_ASH)
     gfx::NativeView parent = platform_util::GetParent(widget->GetNativeView());
     views::corewm::SetChildWindowVisibilityChangesAnimated(parent);
     // No animations should get performed on the window since that will re-order
     // the window stack which will then cause many problems.
     if (parent && parent->parent()) {
       parent->parent()->SetProperty(aura::client::kAnimationsDisabledKey, true);
     }
 
     // TODO(wittman): remove once the new visual style is complete

[sky, 2013/12/02 21:41:46]

Is the TODO still appropriate?

[sadrul, 2013/12/02 22:05:21]

Whoops. I missed this before landing, sorry. Checked with wittman@, and the TODO
applies only to SetProperty, so it should be removed. I will put up a follow-up
CL shortly.

-    widget->GetNativeWindow()->SetProperty(ash::kConstrainedWindowKey, true);
     views::corewm::SetModalParent(
         widget->GetNativeWindow(),
         platform_util::GetParent(widget->GetNativeView()));
 #endif
   }
 
   virtual void ShowDialog(NativeWebContentsModalDialog dialog) OVERRIDE {
     views::Widget* widget = GetWidget(dialog);
 #if defined(USE_AURA)
     scoped_ptr<views::corewm::SuspendChildWindowVisibilityAnimations> suspend;
@@ skipping 135 matching lines @@
 
 namespace web_modal {
 
 NativeWebContentsModalDialogManager* WebContentsModalDialogManager::
 CreateNativeManager(
     NativeWebContentsModalDialogManagerDelegate* native_delegate) {
   return new NativeWebContentsModalDialogManagerViews(native_delegate);
 }
 
 }  // namespace web_modal