Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9410)

Unified Diff: chromeos/dbus/fake_shill_device_client.cc

Issue 978923003: Improve Cellular support in networkingPrivate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_use_guid
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_shill_device_client.cc
diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc
index 5475fd8a62dcf36612e8fa6d4bb6f624ad7e35e6..9b8847653c4fa3462ab7a39843d2f30ae063c76c 100644
--- a/chromeos/dbus/fake_shill_device_client.cc
+++ b/chromeos/dbus/fake_shill_device_client.cc
@@ -92,6 +92,8 @@ void FakeShillDeviceClient::SetProperty(const dbus::ObjectPath& device_path,
const base::Value& value,
const base::Closure& callback,
const ErrorCallback& error_callback) {
+ VLOG(1) << "SetProperty: " << device_path.value() << " " << name << "="
+ << value;
base::DictionaryValue* device_properties = NULL;
if (!stub_devices_.GetDictionaryWithoutPathExpansion(device_path.value(),
&device_properties)) {
@@ -225,11 +227,8 @@ void FakeShillDeviceClient::SetCarrier(const dbus::ObjectPath& device_path,
const std::string& carrier,
const base::Closure& callback,
const ErrorCallback& error_callback) {
- if (!stub_devices_.HasKey(device_path.value())) {
- PostNotFoundError(error_callback);
- return;
- }
- base::MessageLoop::current()->PostTask(FROM_HERE, callback);
+ SetProperty(device_path, shill::kCarrierProperty, base::StringValue(carrier),
+ callback, error_callback);
}
void FakeShillDeviceClient::Reset(const dbus::ObjectPath& device_path,

Powered by Google App Engine
This is Rietveld 408576698