Improve Cellular support in networkingPrivate

chrome/test/data/extensions/api_test/networking_private/chromeos/networking_private_apitest_chromeos.js

Index: chrome/test/data/extensions/api_test/networking_private/chromeos/networking_private_apitest_chromeos.js
diff --git a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js b/chrome/test/data/extensions/api_test/networking_private/chromeos/networking_private_apitest_chromeos.js
similarity index 92%
rename from chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
rename to chrome/test/data/extensions/api_test/networking_private/chromeos/networking_private_apitest_chromeos.js
index c0550b3aff182d0a8c066f1eda4cd1ca780c3b13..67dca776875ef2701035eb83e3f4d4f3f2e3df0c 100644
--- a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
+++ b/chrome/test/data/extensions/api_test/networking_private/chromeos/networking_private_apitest_chromeos.js
@@ -463,6 +463,37 @@ var availableTests = [
               }));
         }));
   },
+  function setCellularProperties() {
+    var done = chrome.test.callbackAdded();

[pneubeck (no reviews), 2015/03/24 16:19:52]

not sure why we ended up using this done/callbackAdded construct in so many
tests, but it shouldn't be required here since you use callbackPass to wrap
every callback.

[stevenjb, 2015/03/25 20:50:10]

Done.

+    var network_guid = "stub_cellular1_guid";
+    chrome.networkingPrivate.getProperties(
+        network_guid,
+        callbackPass(function(result) {
+          assertEq(network_guid, result.GUID);
+          var new_properties = {
+            Priority: 1,
+            Cellular: {
+              Carrier: 'new_carrier',
+            },
+          };
+          chrome.networkingPrivate.setProperties(
+              network_guid,
+              new_properties,
+              callbackPass(function() {
+                chrome.networkingPrivate.getProperties(
+                    network_guid,
+                    callbackPass(function(result) {
+                      // Ensure that the GUID doesn't change.
+                      assertEq(network_guid, result.GUID);
+                      // Ensure that the properties were set.
+                      assertEq(1, result['Priority']);
+                      assertTrue('Cellular' in result);
+                      assertEq('new_carrier', result['Cellular']['Carrier']);
+                      done();
+                    }));
+              }));
+        }));
+  },
   function setVPNProperties() {
     var done = chrome.test.callbackAdded();
     var network_guid = "stub_vpn1_guid";
@@ -513,6 +544,27 @@ var availableTests = [
         }, result);
       }));
   },
+  function getStateCellular() {
+    chrome.networkingPrivate.getState(
+      "stub_cellular1_guid",
+      callbackPass(function(result) {
+        assertEq({
+          "Cellular": {
+            "ActivationState": "NotActivated",
+            "NetworkTechnology": "GSM",
+            "RoamingState": "Home",
+            "SignalStrength": 0,
+            "SupportNetworkScan": false,

[pneubeck (no reviews), 2015/03/24 16:19:52]

this dictionary seems rather huge. Are all of these properties relevant for
(overview) network lists in UI?

[stevenjb, 2015/03/25 20:50:10]

All except SupportNetworkScan are used in the badge. I'm not sure why ONC is
providing that; we don't provide it in NetworkState::GetStateProperties as near
as I can tell. Maybe because it is a boolean?

+          },
+          "Connectable": false,
+          "ConnectionState": "NotConnected",
+          "GUID": "stub_cellular1_guid",
+          "Name": "cellular1",
+          "Source": "Device",
+          "Type": "Cellular",
+        }, result);
+      }));
+  },
   function getStateNonExistent() {
     chrome.networkingPrivate.getState(
       'non_existent',