Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 978863002: Better UI when the machine is shared under a different account (Closed)

Created:
5 years, 9 months ago by kelvinp
Modified:
5 years, 9 months ago
Reviewers:
Lambros, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Better UI when the machine is shared under a different account Currently, when the local computer is shared under a different account, we will show the host with an empty name. In this CL, we will show a message saying, 'This computer is currently is shared under a different account' and allows the user to disable the remote connection. We also hide the pairing management or change PIN entry points when this happened. BUG=456291 Committed: https://crrev.com/f5ac85a3a52b67adfac27fe0ec07d1cf2cff4a84 Cr-Commit-Position: refs/heads/master@{#319213}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Reviewer's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M remoting/resources/remoting_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/webapp/base/html/main.css View 1 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/webapp/crd/html/ui_me2me.html View 1 1 chunk +17 lines, -6 lines 0 comments Download
M remoting/webapp/crd/js/local_host_section.js View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
kelvinp
PTAL
5 years, 9 months ago (2015-03-04 23:02:45 UTC) #3
Jamie
https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd#newcode772 remoting/resources/remoting_strings.grd:772: <message desc="Message displayed when the current computer is shared ...
5 years, 9 months ago (2015-03-05 00:54:12 UTC) #4
Lambros
https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd#newcode772 remoting/resources/remoting_strings.grd:772: <message desc="Message displayed when the current computer is shared ...
5 years, 9 months ago (2015-03-05 01:20:03 UTC) #6
kelvinp
PTAL https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/978863002/diff/20001/remoting/resources/remoting_strings.grd#newcode772 remoting/resources/remoting_strings.grd:772: <message desc="Message displayed when the current computer is ...
5 years, 9 months ago (2015-03-05 01:58:26 UTC) #7
Jamie
lgtm
5 years, 9 months ago (2015-03-05 02:01:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978863002/40001
5 years, 9 months ago (2015-03-05 02:37:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-05 04:00:22 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 04:00:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5ac85a3a52b67adfac27fe0ec07d1cf2cff4a84
Cr-Commit-Position: refs/heads/master@{#319213}

Powered by Google App Engine
This is Rietveld 408576698