Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 978813002: Serializer: still install experimental globals when creating a snapshot. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: still install experimental globals when creating a snapshot. Experimental globals are simply flag values on the builtins object to turn on/off harmony features. We still need to declare them even when we don't turn on harmony features for the snapshot. R=vogelheim@chromium.org Committed: https://crrev.com/bdc7b2f43cf27d535bf0c05a55ca6dcfa2c4a854 Cr-Commit-Position: refs/heads/master@{#26992}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 9 months ago (2015-03-04 14:24:28 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/978813002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/978813002/diff/1/src/bootstrapper.cc#newcode2898 src/bootstrapper.cc:2898: if (!InstallExperimentalNatives()) return; super nitpick: I think I'd ...
5 years, 9 months ago (2015-03-04 14:37:34 UTC) #2
Yang
https://codereview.chromium.org/978813002/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/978813002/diff/1/src/bootstrapper.cc#newcode2898 src/bootstrapper.cc:2898: if (!InstallExperimentalNatives()) return; On 2015/03/04 14:37:34, vogelheim wrote: > ...
5 years, 9 months ago (2015-03-04 14:41:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978813002/20001
5 years, 9 months ago (2015-03-04 14:42:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 15:02:00 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 15:02:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdc7b2f43cf27d535bf0c05a55ca6dcfa2c4a854
Cr-Commit-Position: refs/heads/master@{#26992}

Powered by Google App Engine
This is Rietveld 408576698