Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: src/bootstrapper.cc

Issue 978813002: Serializer: still install experimental globals when creating a snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: address comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 960406d59ad6726b3bb4f3f4cc0dea541d8b1d6f..336002664870bc63cf48260fc9c21a7c92f58829 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2894,10 +2894,9 @@ Genesis::Genesis(Isolate* isolate,
// Install experimental natives. Do not include them into the snapshot as we
// should be able to turn them off at runtime. Re-installing them after
// they have already been deserialized would also fail.
- if (!isolate->serializer_enabled()) {
- if (!InstallExperimentalNatives()) return;
- InitializeExperimentalGlobal();
- }
+ if (!isolate->serializer_enabled() && !InstallExperimentalNatives()) return;
+
+ InitializeExperimentalGlobal();
// The serializer cannot serialize typed arrays. Reset those typed arrays
// for each new context.
« no previous file with comments | « no previous file | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698