Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 978633003: Don't define parameters when visiting a function-typed formal parameter. (Closed)

Created:
5 years, 9 months ago by Paul Berry
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't define parameters when visiting a function-typed formal parameter. BUG=dartbug.com/13179 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A + tests/language/issue13179_test.dart View 1 chunk +12 lines, -5 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 9 months ago (2015-03-03 23:00:59 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-03 23:08:14 UTC) #3
Paul Berry
5 years, 9 months ago (2015-03-04 00:39:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698