chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java - Issue 978623002: New UMA settings fragment for Chrome on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

Issue 978623002: New UMA settings fragment for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Null check removed. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

index e3de19bafbc1a31750bf2c62603582c5c2c929b4..6fed71652e2dd2ad3a303e5d8c1a1f55d13b5bea 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

@@ -151,8 +151,8 @@ public class UmaSessionStats implements NetworkChangeNotifier.ConnectionTypeObse

* Updates the state of the MetricsService to account for the user's preferences.

public void updateMetricsServiceState() {

- boolean mayRecordStats = !PrivacyPreferencesManager.getInstance(mContext)

- .isNeverUploadCrashDump();

+ boolean mayRecordStats =

+ PrivacyPreferencesManager.getInstance(mContext).isUsageAndCrashReportingEnabled();

boolean mayUploadStats = mReportingPermissionManager.isUploadPermitted();

// Re-start the MetricsService with the given parameters.