chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java - Issue 978623002: New UMA settings fragment for Chrome on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java

Issue 978623002: New UMA settings fragment for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Null check removed. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/xml/usage_and_crash_reports_preferences.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java

index 3ed76b447b4e9efa75f5f630f2e10634b0abea41..655a16ce0718972db5407ff2d2bd9a8ba55c4081 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java

@@ -28,7 +28,7 @@ public class FirstRunGlueImpl implements FirstRunGlue {

@Override

public boolean isNeverUploadCrashDump(Context appContext) {

- return PrivacyPreferencesManager.getInstance(appContext).isNeverUploadCrashDump();

+ return !PrivacyPreferencesManager.getInstance(appContext).isUsageAndCrashReportingEnabled();

}

@Override

@@ -55,4 +55,4 @@ public class FirstRunGlueImpl implements FirstRunGlue {

public void openAccountAdder(Fragment fragment) {

AccountAdder.getInstance().addAccount(fragment, AccountAdder.ADD_ACCOUNT_RESULT);

}