Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 978523004: Update UBSAN vptr blacklists to account for startup crashes. (Closed)

Created:
5 years, 9 months ago by inferno
Modified:
5 years, 9 months ago
Reviewers:
Martin Barbella
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update UBSAN vptr blacklists to account for startup crashes. R=mbarbella@chromium.org BUG= Committed: https://crrev.com/5f5661cc03d0f1f1feb5de252883d01ab82c187c Cr-Commit-Position: refs/heads/master@{#319098}

Patch Set 1 #

Patch Set 2 : Add fix for StartPageService startup crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M tools/ubsan/blacklist.txt View 1 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Martin Barbella
lgtm
5 years, 9 months ago (2015-03-04 19:11:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978523004/20001
5 years, 9 months ago (2015-03-04 19:14:45 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-04 19:14:49 UTC) #5
inferno
samsonov@, if you have time, please see if you get some workaround/fixes for these ubsan-vptr ...
5 years, 9 months ago (2015-03-04 19:18:31 UTC) #6
inferno
Committed patchset #2 (id:20001) manually as 5f5661cc03d0f1f1feb5de252883d01ab82c187c (presubmit successful).
5 years, 9 months ago (2015-03-04 19:21:10 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:21:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f5661cc03d0f1f1feb5de252883d01ab82c187c
Cr-Commit-Position: refs/heads/master@{#319098}

Powered by Google App Engine
This is Rietveld 408576698