Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: tools/ubsan/blacklist.txt

Issue 978523004: Update UBSAN vptr blacklists to account for startup crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add fix for StartPageService startup crash Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ubsan/blacklist.txt
diff --git a/tools/ubsan/blacklist.txt b/tools/ubsan/blacklist.txt
index 5b4751fe4ca30892040ac08645c5814f8da0a508..29a2b3a513fe8b86963cff586f3fd6ba627ad7e0 100644
--- a/tools/ubsan/blacklist.txt
+++ b/tools/ubsan/blacklist.txt
@@ -47,6 +47,10 @@ fun:*content*RenderViewObserverTracker*RenderView*
fun:*DatabaseContext*contextDestroyed*
+# FIXME: Cannot handle template function LifecycleObserver<>::setContext,
+# so exclude source file for now.
+src:*LifecycleObserver.h*
+
#############################################################################
# static_cast into itself in the constructor.
@@ -54,12 +58,14 @@ fun:*RefCountedGarbageCollected*makeKeepAlive*
fun:*ThreadSafeRefCountedGarbageCollected*makeKeepAlive*
#############################################################################
-# Accessing data in destructurors where the class has virtual inheritances.
+# Accessing data in destructors where the class has virtual inheritances.
type:*content*RenderWidgetHost*
-# Mangled name for content::RenderViewHostImpl::~RenderViewHostImpl()
-fun:*content*RenderViewHostImpl*
+# Match mangled name for content::RenderViewHostImpl::~RenderViewHostImpl().
+fun:*content*RenderViewHostImplD*
+# Match mangled name for content::RenderThreadImpl::~RenderThreadImpl().
+fun:*content*RenderThreadImplD*
#############################################################################
# Using raw pointer values.
@@ -94,6 +100,13 @@ type:*TestNowSource*
#############################################################################
# UBSan seems to be emit false positives when virtual base classes are
-# involved, see e.g. chromium:448102
+# involved, see e.g. crbug.com/448102.
type:*v8*internal*OFStream*
+
+#############################################################################
+# UBsan is unable to handle static_cast<A*>(nullptr) and crashes on SIGSEGV.
+#
+
+# static_cast<StartPageService*> in StartPageServiceFactory::GetForProfile.
+type:*StartPageService*
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698