Support VP9 video in the BT709 color space.

Support VP9 video in the BT709 color space.

Previously vp9 video was assumed to be in BT601. Now the vp9
color space flag is used to support BT709 as well.

BUG=447716
TEST=media_unittests --gtest_filter='PipelineIntegrationTest*'

Committed: https://crrev.com/a1d1bd0dd33973d7cf0110a1e3bbefafe54037ba
Cr-Commit-Position: refs/heads/master@{#319110}

[watk, 2015-03-03 19:22:51]

watk@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2015-03-03 19:53:30]

looking good, just having some newbie questions for clarification :)

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
media/filters/vpx_video_decoder.cc:465: vpx_image->cs == VPX_CS_BT_709) {
Can vpx_codec_alpha_ be true here?

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
media/filters/vpx_video_decoder.cc:467: } else if (vpx_image->fmt ==
VPX_IMG_FMT_I444) {
Can vpx_image->cs == VPX_CS_BT_709 here?

[watk, 2015-03-03 21:56:45]

Patchset #2 (id:20001) has been deleted

[watk, 2015-03-03 22:01:28]

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
media/filters/vpx_video_decoder.cc:465: vpx_image->cs == VPX_CS_BT_709) {
On 2015/03/03 19:53:30, xhwang wrote:
> Can vpx_codec_alpha_ be true here?

Yeah, it can. Unfortunately we have to choose between alpha and BT709, but I
made the wrong choice! Alpha should be preferred.

https://codereview.chromium.org/978483002/diff/1/media/filters/vpx_video_deco...
media/filters/vpx_video_decoder.cc:467: } else if (vpx_image->fmt ==
VPX_IMG_FMT_I444) {
On 2015/03/03 19:53:30, xhwang wrote:
> Can vpx_image->cs == VPX_CS_BT_709 here?

It can, but we can't support it at the moment :( I added a comment

[xhwang, 2015-03-04 18:07:14]

lgtm % nit

https://codereview.chromium.org/978483002/diff/40001/media/filters/vpx_video_...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/978483002/diff/40001/media/filters/vpx_video_...
media/filters/vpx_video_decoder.cc:472: // Until color space is separated from
format, prefer YV12A over YV12HD.
This seems more like a comment/todo for l.468. Move it up a bit?

[watk, 2015-03-04 18:22:31]

The CQ bit was checked by watk@chromium.org

[watk, 2015-03-04 18:22:31]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/978483002/#ps60001 (title:
"Move comment")

[watk, 2015-03-04 18:23:02]

Thanks, checking the CQ

https://codereview.chromium.org/978483002/diff/40001/media/filters/vpx_video_...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/978483002/diff/40001/media/filters/vpx_video_...
media/filters/vpx_video_decoder.cc:472: // Until color space is separated from
format, prefer YV12A over YV12HD.
On 2015/03/04 18:07:14, xhwang wrote:
> This seems more like a comment/todo for l.468. Move it up a bit?

Done.

[commit-bot: I haz the power, 2015-03-04 18:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/978483002/60001

[commit-bot: I haz the power, 2015-03-04 20:01:43]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-04 20:02:30]

Patchset 3 (id:??) landed as
https://crrev.com/a1d1bd0dd33973d7cf0110a1e3bbefafe54037ba
Cr-Commit-Position: refs/heads/master@{#319110}