Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: media/filters/vpx_video_decoder.cc

Issue 978483002: Support VP9 video in the BT709 color space. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/test/data/bear-vp9-bt709.webm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/vpx_video_decoder.cc
diff --git a/media/filters/vpx_video_decoder.cc b/media/filters/vpx_video_decoder.cc
index dd436796ce1c20500cc5dc38f251fb0b81b9caac..fb9b0af0d36ed0c461ad9b7ead0b5d5e29eda04f 100644
--- a/media/filters/vpx_video_decoder.cc
+++ b/media/filters/vpx_video_decoder.cc
@@ -465,7 +465,12 @@ void VpxVideoDecoder::CopyVpxImageTo(const vpx_image* vpx_image,
codec_format = VideoFrame::YV24;
uv_rows = vpx_image->d_h;
} else if (vpx_codec_alpha_) {
+ // TODO(watk): A limitation of conflating color space with pixel format is
+ // that it's not possible to have BT709 with alpha.
+ // Until color space is separated from format, prefer YV12A over YV12HD.
codec_format = VideoFrame::YV12A;
+ } else if (vpx_image->cs == VPX_CS_BT_709) {
+ codec_format = VideoFrame::YV12HD;
}
gfx::Size size(vpx_image->d_w, vpx_image->d_h);
« no previous file with comments | « no previous file | media/test/data/bear-vp9-bt709.webm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698