Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: Source/core/dom/Node.idl

Issue 978223002: Add [TypeChecking=Interface] to Node interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update test wrt isSameNode() change Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.idl
diff --git a/Source/core/dom/Node.idl b/Source/core/dom/Node.idl
index b6ce66767a006d725fc62955440a5d91c51a4fd3..c4988825e1c5ad745e493f6fe88174751a97edc9 100644
--- a/Source/core/dom/Node.idl
+++ b/Source/core/dom/Node.idl
@@ -22,6 +22,7 @@
[
DependentLifetime,
+ TypeChecking=Interface,
] interface Node : EventTarget {
const unsigned short ELEMENT_NODE = 1;
// FIXME: Attr should not inherit from Node. crbug.com/305105
@@ -74,10 +75,10 @@
DOMString? lookupNamespaceURI(DOMString? prefix);
boolean isDefaultNamespace(DOMString? namespaceURI);
- [CustomElementCallbacks, PerWorldBindings, RaisesException, TypeChecking=Interface] Node insertBefore(Node node, Node? child);
- [CustomElementCallbacks, PerWorldBindings, RaisesException, TypeChecking=Interface] Node appendChild(Node node);
- [CustomElementCallbacks, PerWorldBindings, RaisesException, TypeChecking=Interface] Node replaceChild(Node node, Node child);
- [CustomElementCallbacks, RaisesException, TypeChecking=Interface] Node removeChild(Node child);
+ [CustomElementCallbacks, PerWorldBindings, RaisesException] Node insertBefore(Node node, Node? child);
+ [CustomElementCallbacks, PerWorldBindings, RaisesException] Node appendChild(Node node);
+ [CustomElementCallbacks, PerWorldBindings, RaisesException] Node replaceChild(Node node, Node child);
+ [CustomElementCallbacks, RaisesException] Node removeChild(Node child);
// FIXME: namespaceURI and localName have been moved to Element and Attr.
[MeasureAs=NodeNamespaceURI] readonly attribute DOMString? namespaceURI;
@@ -85,5 +86,5 @@
// FIXME: isSameNode has been removed from the spec:
// https://www.w3.org/Bugs/Public/show_bug.cgi?id=27424
- [MeasureAs=NodeIsSameNode] boolean isSameNode([Default=Undefined] optional Node other);
+ [MeasureAs=NodeIsSameNode] boolean isSameNode(Node? other);
};
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698