Source/core/dom/Node.cpp - Issue 978223002: Add [TypeChecking=Interface] to Node interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 978223002: Add [TypeChecking=Interface] to Node interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update test wrt isSameNode() change Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index 7209be45a0a599d18f9938c3d93e46944d1957d5..4e48695d807058e50229593f7b573406386109bd 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -1431,10 +1431,6 @@ bool Node::offsetInCharacters() const

unsigned short Node::compareDocumentPosition(const Node* otherNode, ShadowTreesTreatment treatment) const

{

- // It is not clear what should be done if |otherNode| is nullptr.

- if (!otherNode)

- return DOCUMENT_POSITION_DISCONNECTED;

if (otherNode == this)

return DOCUMENT_POSITION_EQUIVALENT;

« no previous file with comments | « LayoutTests/fast/dom/incompatible-operations-expected.txt ('k') | Source/core/dom/Node.idl » ('j') | no next file with comments »