Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 978123002: More useful prettyprinting for RefPtr/OwnPtr/DataRef. (Closed)

Created:
5 years, 9 months ago by cbiesinger
Modified:
5 years, 9 months ago
Reviewers:
tony
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

More useful prettyprinting for RefPtr/OwnPtr/DataRef. Example output: m_box = DataRef(WTF::RefPtr((blink::StyleBoxData *)0x32cdd2dd2c8)), R=tony@chromium.org CC=mstensho@opera.com NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191333

Patch Set 1 #

Patch Set 2 : fix param ordering #

Total comments: 2

Patch Set 3 : line length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M Tools/gdb/webkit.py View 1 2 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cbiesinger
5 years, 9 months ago (2015-03-05 01:00:19 UTC) #1
tony
LGTM https://codereview.chromium.org/978123002/diff/20001/Tools/gdb/webkit.py File Tools/gdb/webkit.py (right): https://codereview.chromium.org/978123002/diff/20001/Tools/gdb/webkit.py#newcode375 Tools/gdb/webkit.py:375: return 'DataRef(%s)' % WTFRefOrOwnPtrPrinter(self.val['m_data']).to_string() nit: 80 cols
5 years, 9 months ago (2015-03-05 01:54:10 UTC) #2
cbiesinger
https://codereview.chromium.org/978123002/diff/20001/Tools/gdb/webkit.py File Tools/gdb/webkit.py (right): https://codereview.chromium.org/978123002/diff/20001/Tools/gdb/webkit.py#newcode375 Tools/gdb/webkit.py:375: return 'DataRef(%s)' % WTFRefOrOwnPtrPrinter(self.val['m_data']).to_string() On 2015/03/05 01:54:10, tony wrote: ...
5 years, 9 months ago (2015-03-05 02:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978123002/40001
5 years, 9 months ago (2015-03-05 02:05:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/978123002/40001
5 years, 9 months ago (2015-03-05 02:39:27 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:39:55 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191333

Powered by Google App Engine
This is Rietveld 408576698