More useful prettyprinting for RefPtr/OwnPtr/DataRef.

Tools/gdb/webkit.py

 # Copyright (C) 2010, Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 327 matching lines @@
         start = self.val['m_buffer']
         return self.Iterator(start, start + self.val['m_size'])
 
     def to_string(self):
         return ('%s of length %d, capacity %d'
                 % ('WTF::Vector', self.val['m_size'], self.val['m_capacity']))
 
     def display_hint(self):
         return 'array'
 
+
+# Copied from //tools/gdb/gdb_chrome.py
+def typed_ptr(ptr):
+    """Prints a pointer along with its exact type.
+
+    By default, gdb would print just the address, which takes more
+    steps to interpret.
+    """
+    # Returning this as a cast expression surrounded by parentheses
+    # makes it easier to cut+paste inside of gdb.
+    return '((%s)%s)' % (ptr.dynamic_type, ptr)
+
+
+class WTFRefOrOwnPtrPrinter:
+    def __init__(self, val):
+        self.val = val
+
+    def to_string(self):
+        type_without_param = re.sub(r'<.*>', '', self.val.type.name)
+        return '%s%s' % (type_without_param, typed_ptr(self.val['m_ptr']))
+
+
+class BlinkDataRefPrinter:
+    def __init__(self, val):
+        self.val = val
+
+    def to_string(self):
+        return 'DataRef(%s)' % WTFRefOrOwnPtrPrinter(self.val['m_data']).to_string()

[tony, 2015/03/05 01:54:10]

nit: 80 cols

[cbiesinger, 2015/03/05 02:05:06]

Done.

+
+
 def add_pretty_printers():
     pretty_printers = (
         (re.compile("^WTF::Vector<.*>$"), WTFVectorPrinter),
         (re.compile("^WTF::AtomicString$"), WTFAtomicStringPrinter),
         (re.compile("^WTF::CString$"), WTFCStringPrinter),
         (re.compile("^WTF::String$"), WTFStringPrinter),
         (re.compile("^WTF::StringImpl$"), WTFStringImplPrinter),
         (re.compile("^blink::KURL$"), blinkKURLPrinter),
         (re.compile("^blink::LayoutUnit$"), blinkLayoutUnitPrinter),
         (re.compile("^blink::LayoutPoint$"), blinkLayoutPointPrinter),
         (re.compile("^blink::LayoutSize$"), blinkLayoutSizePrinter),
         (re.compile("^blink::QualifiedName$"), blinkQualifiedNamePrinter),
         (re.compile("^blink::PixelsAndPercent$"), BlinkPixelsAndPercentPrinter),
         (re.compile("^blink::Length$"), BlinkLengthPrinter),
+        (re.compile("^WTF::(Ref|Own)Ptr<.*>$"), WTFRefOrOwnPtrPrinter),
+        (re.compile("^blink::DataRef<.*>$"), BlinkDataRefPrinter),
     )
 
     def lookup_function(val):
         """Function used to load pretty printers; will be passed to GDB."""
         type = val.type
         if type.code == gdb.TYPE_CODE_REF:
             type = type.target()
         type = type.unqualified().strip_typedefs()
         tag = type.tag
         if tag:
@@ skipping 46 matching lines @@
             padding = ''
             while len(stack) > 0:
                 pair = stack.pop()
                 print(padding, pair[1], pair[0])
                 padding = padding + '  '
         else:
             print('Sorry: I don\'t know how to deal with %s yet.' % target_type)
 
 
 PrintPathToRootCommand()