Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 977943002: [Extension Toolbar] Don't synthesize actions for policy extensions (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension Toolbar] Don't synthesize actions for policy extensions Policy extensions weren't installed by the user, and frequently cannot be uninstalled. Similar to component extensions, we shouldn't synthesize actions for these extensions. BUG=463939 Committed: https://crrev.com/b3b2462b4e45fb1722b577415bcb62b1e27ce4aa Cr-Commit-Position: refs/heads/master@{#319669}

Patch Set 1 #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Devlin
Another short one for you, Finnur. :)
5 years, 9 months ago (2015-03-05 19:23:44 UTC) #2
Finnur
You do a great job at making me look more productive. :) LGTM
5 years, 9 months ago (2015-03-06 14:37:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977943002/1
5 years, 9 months ago (2015-03-07 06:52:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 08:52:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977943002/1
5 years, 9 months ago (2015-03-07 16:40:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 18:42:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977943002/1
5 years, 9 months ago (2015-03-09 05:02:57 UTC) #13
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 06:35:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977943002/20001
5 years, 9 months ago (2015-03-09 16:17:09 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 17:33:14 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:33:50 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3b2462b4e45fb1722b577415bcb62b1e27ce4aa
Cr-Commit-Position: refs/heads/master@{#319669}

Powered by Google App Engine
This is Rietveld 408576698