Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7411)

Unified Diff: chrome/common/extensions/manifest_handlers/extension_action_handler.cc

Issue 977943002: [Extension Toolbar] Don't synthesize actions for policy extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_handlers/extension_action_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/extension_action_handler.cc b/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
index a976b004387333bbf8e982bcb3cebfd30ea889ec..1177836aaa674baf0dfcf4272b95009c63cd44f3 100644
--- a/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/extension_action_handler.cc
@@ -61,8 +61,9 @@ bool ExtensionActionHandler::Parse(Extension* extension,
} else { // No key, used for synthesizing an action for extensions with none.
if (!FeatureSwitch::extension_action_redesign()->IsEnabled())
return true; // Do nothing if the switch is off.
- if (Manifest::IsComponentLocation(extension->location()))
- return true; // Don't synthesize actions for component extensions.
+ if (Manifest::IsComponentLocation(extension->location()) ||
+ Manifest::IsPolicyLocation(extension->location()))
+ return true; // Don't synthesize actions for component/policy extensions.
if (extension->manifest()->HasKey(
manifest_keys::kSynthesizeExtensionAction)) {
*error = base::ASCIIToUTF16(base::StringPrintf(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698