Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 977893003: Remove some unused NaCl srpc methods (AttachService, ctor variant) (Closed)

Created:
5 years, 9 months ago by jvoung (off chromium)
Modified:
5 years, 9 months ago
Reviewers:
Derek Schuff
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unused NaCl srpc methods (AttachService, ctor variant). Remove a couple unused fwd declarations and make a Getter const while I'm messing with that file. BUG=none Committed: https://crrev.com/88fe77f9b9d4395f36b0b140ab4dcefc61bfecc3 Cr-Commit-Position: refs/heads/master@{#319159}

Patch Set 1 #

Patch Set 2 : xx #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M components/nacl/renderer/plugin/srpc_client.h View 2 chunks +1 line, -6 lines 0 comments Download
M components/nacl/renderer/plugin/srpc_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/nacl/renderer/plugin/srpc_params.h View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jvoung (off chromium)
5 years, 9 months ago (2015-03-04 20:47:30 UTC) #2
Derek Schuff
lgtm
5 years, 9 months ago (2015-03-04 21:21:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977893003/20001
5 years, 9 months ago (2015-03-04 22:25:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 23:20:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:21:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88fe77f9b9d4395f36b0b140ab4dcefc61bfecc3
Cr-Commit-Position: refs/heads/master@{#319159}

Powered by Google App Engine
This is Rietveld 408576698