Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: components/nacl/renderer/plugin/srpc_params.h

Issue 977893003: Remove some unused NaCl srpc methods (AttachService, ctor variant) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: xx Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/nacl/renderer/plugin/srpc_client.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Parameter types for SRPC Invocation. 5 // Parameter types for SRPC Invocation.
6 6
7 #ifndef COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H 7 #ifndef COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H
8 #define COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H 8 #define COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H
9 9
10 #include "native_client/src/include/nacl_macros.h" 10 #include "native_client/src/include/nacl_macros.h"
11 #include "native_client/src/include/portability_string.h" 11 #include "native_client/src/include/portability_string.h"
12 #include "native_client/src/shared/srpc/nacl_srpc.h" 12 #include "native_client/src/shared/srpc/nacl_srpc.h"
13 13
14 namespace plugin { 14 namespace plugin {
15 15
16 // A utility class that builds and deletes parameter vectors used in rpcs. 16 // A utility class that builds and deletes parameter vectors used in rpcs.
17 class SrpcParams { 17 class SrpcParams {
18 public: 18 public:
19 SrpcParams() { 19 SrpcParams() {
20 memset(ins_, 0, sizeof(ins_)); 20 memset(ins_, 0, sizeof(ins_));
21 memset(outs_, 0, sizeof(outs_)); 21 memset(outs_, 0, sizeof(outs_));
22 } 22 }
23 23
24 SrpcParams(const char* in_types, const char* out_types) {
25 if (!Init(in_types, out_types)) {
26 FreeAll();
27 }
28 }
29
30 ~SrpcParams() { 24 ~SrpcParams() {
31 FreeAll(); 25 FreeAll();
32 } 26 }
33 27
34 bool Init(const char* in_types, const char* out_types); 28 bool Init(const char* in_types, const char* out_types);
35 29
36 NaClSrpcArg** ins() const { return const_cast<NaClSrpcArg**>(ins_); } 30 NaClSrpcArg** ins() const { return const_cast<NaClSrpcArg**>(ins_); }
37 NaClSrpcArg** outs() const { return const_cast<NaClSrpcArg**>(outs_); } 31 NaClSrpcArg** outs() const { return const_cast<NaClSrpcArg**>(outs_); }
38 32
39 private: 33 private:
40 NACL_DISALLOW_COPY_AND_ASSIGN(SrpcParams); 34 NACL_DISALLOW_COPY_AND_ASSIGN(SrpcParams);
41 void FreeAll(); 35 void FreeAll();
42 // The ins_ and outs_ arrays contain one more element, to hold a NULL pointer 36 // The ins_ and outs_ arrays contain one more element, to hold a NULL pointer
43 // to indicate the end of the list. 37 // to indicate the end of the list.
44 NaClSrpcArg* ins_[NACL_SRPC_MAX_ARGS + 1]; 38 NaClSrpcArg* ins_[NACL_SRPC_MAX_ARGS + 1];
45 NaClSrpcArg* outs_[NACL_SRPC_MAX_ARGS + 1]; 39 NaClSrpcArg* outs_[NACL_SRPC_MAX_ARGS + 1];
46 }; 40 };
47 41
48 } // namespace plugin 42 } // namespace plugin
49 43
50 #endif // COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H 44 #endif // COMPONENTS_NACL_RENDERER_PLUGIN_SRPC_PARAMS_H
OLDNEW
« no previous file with comments | « components/nacl/renderer/plugin/srpc_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698