Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

Issue 977873002: Files.app: Add error fields to MetadataItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused assert Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
index 4a5a04acba320d14fa7d9e8c38105291640b3af5..e9801d60ff1d73205f33c4e55bb56e6d9fd3360b 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
@@ -81,10 +81,27 @@ function testMetadataCacheItemHasFreshCache() {
assertTrue(item.hasFreshCache(['propertyA']));
}
-function testMetadataCacheShouldNotUpdateBeforeInvalidation() {
+function testMetadataCacheItemShouldNotUpdateBeforeInvalidation() {
var item = new MetadataCacheItem();
item.startRequests(1, item.createRequests(['property']));
item.storeProperties(1, {property: 'value1'});
item.storeProperties(2, {property: 'value2'});
assertEquals('value1', item.get(['property']).property);
}
+
+function testMetadataCacheItemError() {
+ var item = new MetadataCacheItem();
+ item.startRequests(1, item.createRequests(['property']));
+ item.storeProperties(
+ 1, {property: 'value1', propertyError: new Error('Error')});
+ assertEquals(undefined, item.get(['property']).property);
+ assertEquals('Error', item.get(['property']).propertyError.message);
+}
+
+function testMetadataCacheItemErrorShouldNotFetchedDirectly() {
+ var item = new MetadataCacheItem();
+ item.startRequests(1, item.createRequests(['property']));
+ item.storeProperties(
+ 1, {property: 'value1', propertyError: new Error('Error')});
+ assertThrows(function() { item.get(['propertyError']); });
+}

Powered by Google App Engine
This is Rietveld 408576698