Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/extensions/extension_management.cc

Issue 977673002: Additional tracing and histogram in Extensions startup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management.cc
diff --git a/chrome/browser/extensions/extension_management.cc b/chrome/browser/extensions/extension_management.cc
index e9b922ff442568ecc542435b0cd43952b8cb6ca5..4d3adbcc6a19e60fe85f186d96e28f4d83998a0e 100644
--- a/chrome/browser/extensions/extension_management.cc
+++ b/chrome/browser/extensions/extension_management.cc
@@ -9,9 +9,11 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "base/prefs/pref_service.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
+#include "base/trace_event/trace_event.h"
#include "base/version.h"
#include "chrome/browser/extensions/extension_management_constants.h"
#include "chrome/browser/extensions/extension_management_internal.h"
@@ -35,6 +37,8 @@ namespace extensions {
ExtensionManagement::ExtensionManagement(PrefService* pref_service)
: pref_service_(pref_service) {
+ TRACE_EVENT0("browser,startup",
+ "ExtensionManagement::ExtensionManagement::ctor");
pref_change_registrar_.Init(pref_service_);
base::Closure pref_change_callback = base::Bind(
&ExtensionManagement::OnExtensionPrefChanged, base::Unretained(this));
@@ -234,6 +238,8 @@ bool ExtensionManagement::CheckMinimumVersion(
}
void ExtensionManagement::Refresh() {
+ TRACE_EVENT0("browser,startup", "ExtensionManagement::Refresh");
+ SCOPED_UMA_HISTOGRAM_TIMER("Extensions.ExtensionManagement_RefreshTime");
// Load all extension management settings preferences.
const base::ListValue* allowed_list_pref =
static_cast<const base::ListValue*>(LoadPreference(
@@ -474,6 +480,8 @@ ExtensionManagementFactory::~ExtensionManagementFactory() {
KeyedService* ExtensionManagementFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
+ TRACE_EVENT0("browser,startup",
+ "ExtensionManagementFactory::BuildServiceInstanceFor");
return new ExtensionManagement(
Profile::FromBrowserContext(context)->GetPrefs());
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | components/keyed_service/core/keyed_service_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698