Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/extensions/extension_management.cc

Issue 977673002: Additional tracing and histogram in Extensions startup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_management.h" 5 #include "chrome/browser/extensions/extension_management.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/metrics/histogram_macros.h"
12 #include "base/prefs/pref_service.h" 13 #include "base/prefs/pref_service.h"
13 #include "base/strings/string16.h" 14 #include "base/strings/string16.h"
14 #include "base/strings/string_util.h" 15 #include "base/strings/string_util.h"
16 #include "base/trace_event/trace_event.h"
15 #include "base/version.h" 17 #include "base/version.h"
16 #include "chrome/browser/extensions/extension_management_constants.h" 18 #include "chrome/browser/extensions/extension_management_constants.h"
17 #include "chrome/browser/extensions/extension_management_internal.h" 19 #include "chrome/browser/extensions/extension_management_internal.h"
18 #include "chrome/browser/extensions/external_policy_loader.h" 20 #include "chrome/browser/extensions/external_policy_loader.h"
19 #include "chrome/browser/extensions/external_provider_impl.h" 21 #include "chrome/browser/extensions/external_provider_impl.h"
20 #include "chrome/browser/extensions/permissions_based_management_policy_provider .h" 22 #include "chrome/browser/extensions/permissions_based_management_policy_provider .h"
21 #include "chrome/browser/extensions/standard_management_policy_provider.h" 23 #include "chrome/browser/extensions/standard_management_policy_provider.h"
22 #include "chrome/browser/profiles/incognito_helpers.h" 24 #include "chrome/browser/profiles/incognito_helpers.h"
23 #include "chrome/browser/profiles/profile.h" 25 #include "chrome/browser/profiles/profile.h"
24 #include "components/crx_file/id_util.h" 26 #include "components/crx_file/id_util.h"
25 #include "components/keyed_service/content/browser_context_dependency_manager.h" 27 #include "components/keyed_service/content/browser_context_dependency_manager.h"
26 #include "components/pref_registry/pref_registry_syncable.h" 28 #include "components/pref_registry/pref_registry_syncable.h"
27 #include "extensions/browser/pref_names.h" 29 #include "extensions/browser/pref_names.h"
28 #include "extensions/common/manifest_constants.h" 30 #include "extensions/common/manifest_constants.h"
29 #include "extensions/common/permissions/api_permission_set.h" 31 #include "extensions/common/permissions/api_permission_set.h"
30 #include "extensions/common/permissions/permission_set.h" 32 #include "extensions/common/permissions/permission_set.h"
31 #include "extensions/common/url_pattern.h" 33 #include "extensions/common/url_pattern.h"
32 #include "url/gurl.h" 34 #include "url/gurl.h"
33 35
34 namespace extensions { 36 namespace extensions {
35 37
36 ExtensionManagement::ExtensionManagement(PrefService* pref_service) 38 ExtensionManagement::ExtensionManagement(PrefService* pref_service)
37 : pref_service_(pref_service) { 39 : pref_service_(pref_service) {
40 TRACE_EVENT0("browser,startup",
41 "ExtensionManagement::ExtensionManagement::ctor");
38 pref_change_registrar_.Init(pref_service_); 42 pref_change_registrar_.Init(pref_service_);
39 base::Closure pref_change_callback = base::Bind( 43 base::Closure pref_change_callback = base::Bind(
40 &ExtensionManagement::OnExtensionPrefChanged, base::Unretained(this)); 44 &ExtensionManagement::OnExtensionPrefChanged, base::Unretained(this));
41 pref_change_registrar_.Add(pref_names::kInstallAllowList, 45 pref_change_registrar_.Add(pref_names::kInstallAllowList,
42 pref_change_callback); 46 pref_change_callback);
43 pref_change_registrar_.Add(pref_names::kInstallDenyList, 47 pref_change_registrar_.Add(pref_names::kInstallDenyList,
44 pref_change_callback); 48 pref_change_callback);
45 pref_change_registrar_.Add(pref_names::kInstallForceList, 49 pref_change_registrar_.Add(pref_names::kInstallForceList,
46 pref_change_callback); 50 pref_change_callback);
47 pref_change_registrar_.Add(pref_names::kAllowedInstallSites, 51 pref_change_registrar_.Add(pref_names::kAllowedInstallSites,
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 return true; 231 return true;
228 bool meets_requirement = extension->version()->CompareTo( 232 bool meets_requirement = extension->version()->CompareTo(
229 *iter->second->minimum_version_required) >= 0; 233 *iter->second->minimum_version_required) >= 0;
230 // Output a human readable version string for prompting if necessary. 234 // Output a human readable version string for prompting if necessary.
231 if (!meets_requirement && required_version) 235 if (!meets_requirement && required_version)
232 *required_version = iter->second->minimum_version_required->GetString(); 236 *required_version = iter->second->minimum_version_required->GetString();
233 return meets_requirement; 237 return meets_requirement;
234 } 238 }
235 239
236 void ExtensionManagement::Refresh() { 240 void ExtensionManagement::Refresh() {
241 TRACE_EVENT0("browser,startup", "ExtensionManagement::Refresh");
242 SCOPED_UMA_HISTOGRAM_TIMER("Extensions.ExtensionManagement_RefreshTime");
237 // Load all extension management settings preferences. 243 // Load all extension management settings preferences.
238 const base::ListValue* allowed_list_pref = 244 const base::ListValue* allowed_list_pref =
239 static_cast<const base::ListValue*>(LoadPreference( 245 static_cast<const base::ListValue*>(LoadPreference(
240 pref_names::kInstallAllowList, true, base::Value::TYPE_LIST)); 246 pref_names::kInstallAllowList, true, base::Value::TYPE_LIST));
241 // Allow user to use preference to block certain extensions. Note that policy 247 // Allow user to use preference to block certain extensions. Note that policy
242 // managed forcelist or whitelist will always override this. 248 // managed forcelist or whitelist will always override this.
243 const base::ListValue* denied_list_pref = 249 const base::ListValue* denied_list_pref =
244 static_cast<const base::ListValue*>(LoadPreference( 250 static_cast<const base::ListValue*>(LoadPreference(
245 pref_names::kInstallDenyList, false, base::Value::TYPE_LIST)); 251 pref_names::kInstallDenyList, false, base::Value::TYPE_LIST));
246 const base::DictionaryValue* forced_list_pref = 252 const base::DictionaryValue* forced_list_pref =
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 : BrowserContextKeyedServiceFactory( 473 : BrowserContextKeyedServiceFactory(
468 "ExtensionManagement", 474 "ExtensionManagement",
469 BrowserContextDependencyManager::GetInstance()) { 475 BrowserContextDependencyManager::GetInstance()) {
470 } 476 }
471 477
472 ExtensionManagementFactory::~ExtensionManagementFactory() { 478 ExtensionManagementFactory::~ExtensionManagementFactory() {
473 } 479 }
474 480
475 KeyedService* ExtensionManagementFactory::BuildServiceInstanceFor( 481 KeyedService* ExtensionManagementFactory::BuildServiceInstanceFor(
476 content::BrowserContext* context) const { 482 content::BrowserContext* context) const {
483 TRACE_EVENT0("browser,startup",
484 "ExtensionManagementFactory::BuildServiceInstanceFor");
477 return new ExtensionManagement( 485 return new ExtensionManagement(
478 Profile::FromBrowserContext(context)->GetPrefs()); 486 Profile::FromBrowserContext(context)->GetPrefs());
479 } 487 }
480 488
481 content::BrowserContext* ExtensionManagementFactory::GetBrowserContextToUse( 489 content::BrowserContext* ExtensionManagementFactory::GetBrowserContextToUse(
482 content::BrowserContext* context) const { 490 content::BrowserContext* context) const {
483 return chrome::GetBrowserContextRedirectedInIncognito(context); 491 return chrome::GetBrowserContextRedirectedInIncognito(context);
484 } 492 }
485 493
486 void ExtensionManagementFactory::RegisterProfilePrefs( 494 void ExtensionManagementFactory::RegisterProfilePrefs(
487 user_prefs::PrefRegistrySyncable* user_prefs) { 495 user_prefs::PrefRegistrySyncable* user_prefs) {
488 user_prefs->RegisterDictionaryPref( 496 user_prefs->RegisterDictionaryPref(
489 pref_names::kExtensionManagement, 497 pref_names::kExtensionManagement,
490 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 498 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
491 } 499 }
492 500
493 } // namespace extensions 501 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | components/keyed_service/core/keyed_service_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698