Issue 977133002: Revert of Adding linear interpolation to rgb->yuv conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 977133002: Revert of Adding linear interpolation to rgb->yuv conversion (Closed)

Created:
5 years, 9 months ago by joshualitt

Modified:
5 years, 9 months ago

Reviewers:
scroggo, sugoi1, bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Adding linear interpolation to rgb->yuv conversion (patchset #1 id:1 of https://codereview.chromium.org/973563002/) Reason for revert: Speculative revert to see if this unblocks the deps roll Original issue's description: > Adding linear interpolation to rgb->yuv conversion > > When the UV planes are smaller than the Y plane, doing the upscaling in nearest mode was creating artefacts, so I changed it to use linear interpolation to fix the issue. > > BUG=460380 > > Committed: https://skia.googlesource.com/skia/+/cd9d42c5167a50f1bf20e969343556d61354171b TBR=bsalomon@google.com,scroggo@google.com,reed@google.com,sugoi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460380 Committed: https://skia.googlesource.com/skia/+/b8410601e4647e9dea79820436afe7fd4d898875

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -15 lines)			Patch
	M	src/gpu/effects/GrYUVtoRGBEffect.cpp	View		2 chunks	+6 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Adding linear interpolation to rgb->yuv conversion

5 years, 9 months ago (2015-03-04 17:55:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/977133002/1

5 years, 9 months ago (2015-03-04 17:56:06 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 17:56:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b8410601e4647e9dea79820436afe7fd4d898875