Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 976913002: Add '--adb-keys-file $HOME/.android/*.pub' to all bot provision_devices calls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index a36a7305848cbe2ad7b70b79bc350920aeaaed02..43dabb481916ab2f9f9ca315cbdc952b807679ee 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import glob
import os
import re
import urllib
@@ -358,10 +359,15 @@ class AndroidApi(recipe_api.RecipeApi):
def provision_devices(self, skip_wipe=False, disable_location=False,
min_battery_level=None, disable_network=False,
disable_java_debug=False, reboot_timeout=None,
+ no_adb_keys_files=False,
**kwargs):
args = ['-t', self.m.chromium.c.BUILD_CONFIG]
if skip_wipe:
args.append('--skip-wipe')
+ if not no_adb_keys_files:
navabi 2015/03/04 00:19:23 This option is for if in the future some bots may
jbudorick 2015/03/04 00:23:50 I don't really have a problem with having an optio
navabi 2015/03/04 00:56:38 I agree. Done.
+ if glob.glob(os.path.join(os.environ['HOME'], '.android', '*.pub')):
+ args.append('--adb-key-files %s' % os.path.join(os.environ['HOME'],
+ '.android', '*.pub'))
if disable_location:
args.append('--disable-location')
if reboot_timeout is not None:
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698