Add '--adb-keys-file $HOME/.android/*.pub' to all bot provision_devices calls.

scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import glob
 import os
 import re
 import urllib
 
 from infra.libs.infra_types import freeze
 from slave import recipe_api
 
 INSTRUMENTATION_TESTS = freeze([
   {
     'test': 'AndroidWebViewTest',
@@ skipping 336 matching lines @@
       link = ('https://code.google.com/p/chromium/issues/entry?%s' %
         urllib.urlencode(params))
       f.result.presentation.links.update({
         'report a bug': link
       })
       raise
 
   def provision_devices(self, skip_wipe=False, disable_location=False,
                         min_battery_level=None, disable_network=False,
                         disable_java_debug=False, reboot_timeout=None,
+                        no_adb_keys_files=False,
                         **kwargs):
     args = ['-t', self.m.chromium.c.BUILD_CONFIG]
     if skip_wipe:
       args.append('--skip-wipe')
+    if not no_adb_keys_files:

[navabi, 2015/03/04 00:19:23]

This option is for if in the future some bots may not want to write adb keys. We
can also take this out as the provision_devices script will not fail if a path
that does not exist is specified.

[jbudorick, 2015/03/04 00:23:50]

I don't really have a problem with having an option, but the double negative
makes it _really_ clunky. Why not just something like "write_adb_keys_files"
that defaults to True? I think "if write_adb_keys_files" reads more cleanly than
"if not no_adb_keys_files".

[navabi, 2015/03/04 00:56:38]

I agree. Done.

+      if glob.glob(os.path.join(os.environ['HOME'], '.android', '*.pub')):
+        args.append('--adb-key-files %s' % os.path.join(os.environ['HOME'],
+                                                        '.android', '*.pub'))
     if disable_location:
       args.append('--disable-location')
     if reboot_timeout is not None:
       assert isinstance(reboot_timeout, int)
       assert reboot_timeout > 0
       args.extend(['--reboot-timeout', reboot_timeout])
     if min_battery_level is not None:
       assert isinstance(min_battery_level, int)
       assert min_battery_level >= 0
       assert min_battery_level <= 100
@@ skipping 355 matching lines @@
 
     self.m.gsutil.upload(
         source=self.coverage_dir.join('coverage_html'),
         bucket='chrome-code-coverage',
         dest=gs_dest,
         args=['-R'],
         name='upload coverage report',
         link_name='Coverage report',
         version='4.7',
         **kwargs)